Graduate PSReadLine feature and add UseLegacyReadLine #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
rjmholt
approved these changes
Oct 30, 2019
| // We also want it if we are either: | ||
| // * On Windows on any version OR | ||
| // * On Linux or macOS on any version greater than or equal to 7 | ||
| var shouldUsePSReadLine = enableConsoleRepl && !useLegacyReadLine |
There was a problem hiding this comment.
Suggested change
| var shouldUsePSReadLine = enableConsoleRepl && !useLegacyReadLine | |
| bool shouldUsePSReadLine = enableConsoleRepl && !useLegacyReadLine |
| // * On Windows on any version OR | ||
| // * On Linux or macOS on any version greater than or equal to 7 | ||
| var shouldUsePSReadLine = enableConsoleRepl && !useLegacyReadLine | ||
| && (VersionUtils.IsWindows || (!VersionUtils.IsWindows && !VersionUtils.IsPS6)); |
There was a problem hiding this comment.
Shouldn't (IsWindows || (!IsWindows && IsPS6) be the same as (IsWindows || !IsPS6)?
There was a problem hiding this comment.
Good call - fixed!
rjmholt
reviewed
Oct 30, 2019
| // Stdio server can't support an integrated console so we pass in false. | ||
| // Stdio server can't support an integrated console so we pass in false for | ||
| // enableConsoleRepl and useLegacyReadLine. | ||
| false, |
There was a problem hiding this comment.
Possible to use named args here?
|
Hopefully we can slightly reduce the number of files a change like this touches in the binary cmdlet refactor! |
rjmholt
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops checking for PSReadLine feature flag in the feature flags passed in.
Instead, it plumbs a
UseLegacyReadLineparameter which allows the ability to force using the Legacy ReadLine experience (for situations like accessibility that require removing PSRL).I have a separate PR on the vscode-powershell side taking advantage of this here: PowerShell/vscode-powershell#2262