Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make startup banner simpler #1141

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Jan 2, 2020

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was nice while it lasted :/

@bergmeister
Copy link
Contributor

Thank god for that, I hated the banner, why do we need a banner at all?

@rjmholt
Copy link
Contributor Author

rjmholt commented Jan 3, 2020

why do we need a banner at all?

A lot of people don't realise there's a difference between the integrated console and normal PowerShell. The banner helps them see where they are and helps us see when bug reports belong elsewhere.

Also it seemed like a fun thing that other CLI tools do, especially ones that put you in some kind of an environment like the Azure Functions CLI.

But hey, some people didn't like it (some being more vitriolic than others) and we're getting rid of it in a single cycle. That's how the preview is supposed to work.

And if you want it back, you can put it in your profile.

We're keeping the little banner (with an opt-out) just so that it's clear which console you're in by default.

@bergmeister
Copy link
Contributor

bergmeister commented Jan 3, 2020

Yh, I agree, that's the point of previews: experiment and revert mistakes quickly.
One can differentiate the terminals in the dropdown but one cannot even read it due to its length. Maybe shortening it to something like PS Integrated Terminal or PSIC (although most people will be rather confused by that acronym)
image

@TylerLeonhardt
Copy link
Member

@bergmeister I think that'd be a change in vscode-powershell but I like PS Integrated Console. Helps us stand out from just pwsh or powershell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview: Should be Toggleable Settings for Integrated Terminal Banner
3 participants