Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probe .NET Framework dir for dependencies #1151

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Jan 10, 2020

Fixes PowerShell/vscode-powershell#2393.

Allows loading of netstandard.dll on downlevel .NET Framework versions.

We falsely assumed that getting PowerShell to load an assembly module would automatically resolve dependencies in the same directory, but this is actually a property of PowerShell 6+ rather than .NET.

Now we look in the .NET Framework dir on an assembly resolve event before looking in the shared dependencies directory.

@rjmholt
Copy link
Contributor Author

rjmholt commented Jan 10, 2020

Tested on WinSrv2016 with .NET 4.6.2 and 4.7

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Preview] Clean Preview install on Windows 2016 - Exception encountered starting EditorServices
2 participants