Add tooltip to completions ParameterValue #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkeithhill
reviewed
Jan 10, 2020
src/PowerShellEditorServices/Services/TextDocument/Handlers/CompletionHandler.cs
Outdated
Show resolved
Hide resolved
TylerLeonhardt
commented
Jan 10, 2020
src/PowerShellEditorServices/Services/TextDocument/Handlers/CompletionHandler.cs
Outdated
Show resolved
Hide resolved
rkeithhill
reviewed
Jan 10, 2020
| detailString = completionDetails.ToolTipText; | ||
| break; | ||
| case CompletionType.ParameterName: | ||
| // Look for type encoded in the tooltip for parameters and variables. |
There was a problem hiding this comment.
Also, now you are just looking at parameter names (not variables). Should this also case on Variable?
There was a problem hiding this comment.
Variables is on line 207?
There was a problem hiding this comment.
oh I need to move it down gotcha
rkeithhill
reviewed
Jan 10, 2020
src/PowerShellEditorServices/Services/TextDocument/Handlers/CompletionHandler.cs
Outdated
Show resolved
Hide resolved
rjmholt
approved these changes
Jan 10, 2020
src/PowerShellEditorServices/Services/TextDocument/Handlers/CompletionHandler.cs
Outdated
Show resolved
Hide resolved
…Leonhardt/PowerShellEditorServices into handle-parameter-value-completions
|
Issues
======
- Added 1
Complexity increasing per file
==============================
- src/PowerShellEditorServices/Services/TextDocument/Handlers/CompletionHandler.cs 1
See the complete overview on Codacy |
TylerLeonhardt
commented
Jan 10, 2020
src/PowerShellEditorServices/Services/TextDocument/Handlers/CompletionHandler.cs
Show resolved
Hide resolved
rkeithhill
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved it to a switch so it's easier to read. This will show the tooltips for
ParameterValuefixes PowerShell/vscode-powershell#2405