Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure log directory is created #1219

Merged
merged 2 commits into from
Mar 9, 2020
Merged

Ensure log directory is created #1219

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aeea621
Ensure log directory is created
TylerLeonhardt Mar 5, 2020
4a0bbaf
remove duplicate check
TylerLeonhardt Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/PowerShellEditorServices.Hosting/Commands/StartEditorServicesCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,14 +298,17 @@ private void StartLogging()

private string GetLogDirPath()
{
if (!string.IsNullOrEmpty(LogPath))
string logDir = !string.IsNullOrEmpty(LogPath)
? Path.GetDirectoryName(LogPath)
: Path.GetDirectoryName(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location));

// Ensure logDir exists
if (!Directory.Exists(logDir))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this test; Directory.CreateDirectory() is a no-op if it already exists

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

{
return Path.GetDirectoryName(LogPath);
Directory.CreateDirectory(logDir);
}

return Path.GetDirectoryName(
Path.GetDirectoryName(
Assembly.GetExecutingAssembly().Location));
return logDir;
}

private void RemovePSReadLineForStartup()
Expand Down