Update PackageManagement #1239

TylerLeonhardt · 2020-03-23T19:31:18Z

I don't really want this at startup... but it's the best place for it, unfortunately.

This adds a feature to update the users version of PackageManagement if they have a bad version.

vscode-powershell settings PR: PowerShell/vscode-powershell#2651

rjmholt

I see this is in the GetCommandHandler -- when's that fired? Is putting this installation option in the middle of that conflating two otherwise unrelated functionalities? Is there an earlier or separate point at which we could attempt installing a newer PackageManagement version?

Also will installing a newer PackageManagement version also necessitate an upgrade to PowerShellGet?

src/PowerShellEditorServices/Services/PowerShellContext/Handlers/GetCommandHandler.cs

src/PowerShellEditorServices/Services/PowerShellContext/Handlers/GetVersionHandler.cs

src/PowerShellEditorServices/Services/PowerShellContext/Handlers/GetCommandHandler.cs

test/PowerShellEditorServices.Test.E2E/LanguageServerProtocolMessageTests.cs

TylerLeonhardt · 2020-04-21T02:04:29Z

src/PowerShellEditorServices/Services/PowerShellContext/Handlers/GetVersionHandler.cs

+                        new MessageActionItem
+                        {
+                            Title = "Not now"
+                        }


I'm not adding a "don't tell me ever again" because:

I don't know how to set a setting in the client from the server without adding yet another custom message

I kinda wanna make it hard to find the setting to disable this because they really should update their PackageManagement...

TylerLeonhardt · 2020-04-21T02:36:46Z

src/PowerShellEditorServices/Services/PowerShellContext/Handlers/GetVersionHandler.cs

+                    PSCommand psCommand = new PSCommand()
+                        .AddCommand("Install-Module")
+                            .AddParameter("Name", "PackageManagement")
+                            .AddParameter("Force")
+                            .AddParameter("MinimumVersion", s_desiredPackageManagementVersion)
+                            .AddParameter("Scope", "CurrentUser")
+                            .AddParameter("AllowClobber");


So apparently because PowerShell is silly.... psCommand.Commands[0].CommandText just prints out Install-Module.. which sucks. I've opened an issue but this feature is only for Windows PowerShell so... RIP.

Three options:

leave it like that...

add logic to PowerShellContextService to print params as well...

use ExecuteScriptStringAsync async instead and put a script in here instead of using PSCommand...

Thoughts @SeeminglyScience @rjmholt?

Where does this print?

It's here. Line 688 if I messed up the URL. It crashes my phone's browser because it's so damn big

https://www.github.com/PowerShell/PowerShellEditorServices/tree/master/src%2FPowerShellEditorServices%2FServices%2FPowerShellContext%2FPowerShellContextService.cs#L688

I'd either use ExecuteScriptStringAsync or just bundle the module like we do with PSReadLine. Or just don't show it as input

ExecuteScriptStringAsync

I'm trying to avoid this one because apparently it doesn't play nice with ConstrainedLanguage mode? #1221 (comment)

and we wanna support that...

just bundle the module like we do with PSReadLine

We'd have to tack it to the front of the PSModulePath then :/

just don't show it as input

Unfortunately, this is probably the best option... although I wanted to show the user the command we're running so they could modify it if they have things like proxies or want to do AllUsers scope or whatever.

Oh sorry, I mean where does the user see the printed output? I'm inferring from above that it looks like another command shown in the console. I think it's preferable to either not show it or fudge what's shown in some way if that's possible (like print a custom string or something)

Oh sorry, I mean where does the user see the printed output?

Yeah in the PSIC. It just shows Install-Module. Nothing else.

I've added an InputString to ExecutionOptions so that one can overwrite what gets put into History and sent to the Host.

so instead of that, I'm shelling out to powershell.exe... which would mean that as long as PackageManagement wasn't loaded in the session, the user won't have to restart their session.

TylerLeonhardt · 2020-04-23T16:00:02Z

@SeeminglyScience @rjmholt this is a much smaller PR now.

src/PowerShellEditorServices/Services/PowerShellContext/Handlers/GetVersionHandler.cs

TylerLeonhardt · 2020-04-27T19:52:41Z

Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
           

Complexity increasing per file
==============================
- src/PowerShellEditorServices/Services/PowerShellContext/Handlers/GetVersionHandler.cs  2

See the complete overview on Codacy

MSIH · 2020-06-13T15:02:26Z

I am getting this error on some of my windows servers:

powershell.exe -NoLogo -NoProfile -Command 'Install-Module -Name PackageManagement -Force -MinimumVersion 1.4.6 -Scope CurrentUser -AllowClobber'

WARNING: Unable to resolve package source 'https://www.powershellgallery.com/api/v2'.

PackageManagement\Install-Package : No match was found for the specified search criteria and module name 'PackageManagement'. 

Try Get-PSRepository to see all available registered module repositories.
At C:\Program Files\WindowsPowerShell\Modules\PowerShellGet\1.0.0.1\PSModule.psm1:1772 char:21
+ ...          $null = PackageManagement\Install-Package @PSBoundParameters
+                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (Microsoft.Power....InstallPackage:InstallPackage) [Install-Package], Exception
    + FullyQualifiedErrorId : NoMatchFoundForCriteria,Microsoft.PowerShell.PackageManagement.Cmdlets.InstallPackage

I was able to fix the problem by adding code to force to use TLS 1.2. Could you please update the command to use TLS 1.2?

[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12
Install-Module -Name PackageManagement -Force -MinimumVersion 1.4.6 -Scope CurrentUser -AllowClobber

MSIH · 2020-06-16T15:39:19Z

src/PowerShellEditorServices/Services/PowerShellContext/Handlers/GetVersionHandler.cs

+                {
+                    StringBuilder errors = new StringBuilder();
+                    await _powerShellContextService.ExecuteScriptStringAsync(
+                        "powershell.exe -NoLogo -NoProfile -Command 'Install-Module -Name PackageManagement -Force -MinimumVersion 1.4.6 -Scope CurrentUser -AllowClobber'",


This no longer works because the site requires TLS 1.2. I would recommend added code to force to use TLS 1.2

powershell.exe -NoLogo -NoProfile -Command '[Net.ServicePointManager]::SecurityProtocol=[Net.SecurityProtocolType]::Tls12; Install-Module -Name PackageManagement -Force -MinimumVersion 1.4.6 -Scope CurrentUser -AllowClobber

rjmholt self-requested a review March 24, 2020 21:30

rjmholt reviewed Mar 24, 2020

View reviewed changes

TylerLeonhardt force-pushed the update-packagemanagement branch from fda75a5 to 62f2763 Compare April 19, 2020 20:59

rjmholt reviewed Apr 21, 2020

View reviewed changes

src/PowerShellEditorServices/Services/PowerShellContext/Handlers/GetVersionHandler.cs Outdated Show resolved Hide resolved

TylerLeonhardt mentioned this pull request Apr 21, 2020

Add setting for the PackageManagement update feature PowerShell/vscode-powershell#2651

Merged

4 tasks

TylerLeonhardt commented Apr 21, 2020

View reviewed changes

src/PowerShellEditorServices/Services/PowerShellContext/Handlers/GetCommandHandler.cs Outdated Show resolved Hide resolved

TylerLeonhardt commented Apr 21, 2020

View reviewed changes

test/PowerShellEditorServices.Test.E2E/LanguageServerProtocolMessageTests.cs Outdated Show resolved Hide resolved

TylerLeonhardt commented Apr 21, 2020

View reviewed changes

TylerLeonhardt marked this pull request as ready for review April 21, 2020 02:37

TylerLeonhardt force-pushed the update-packagemanagement branch from 6fe3e48 to 81a3801 Compare April 21, 2020 22:22

prompt to update PackageManagement if it is older than 1.4.6

a9ced48

TylerLeonhardt force-pushed the update-packagemanagement branch from 81a3801 to a9ced48 Compare April 21, 2020 22:25

rjmholt approved these changes Apr 27, 2020

View reviewed changes

src/PowerShellEditorServices/Services/PowerShellContext/Handlers/GetVersionHandler.cs Outdated Show resolved Hide resolved

src/PowerShellEditorServices/Services/PowerShellContext/Handlers/GetVersionHandler.cs Outdated Show resolved Hide resolved

rob's feedback

3526a8b

SeeminglyScience approved these changes Apr 28, 2020

View reviewed changes

TylerLeonhardt merged commit f4c3f79 into PowerShell:master Apr 28, 2020

TylerLeonhardt deleted the update-packagemanagement branch April 28, 2020 17:15

MSIH reviewed Jun 16, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update PackageManagement #1239

Update PackageManagement #1239

TylerLeonhardt commented Mar 23, 2020 •

edited

Loading

rjmholt left a comment

TylerLeonhardt Apr 21, 2020

TylerLeonhardt Apr 21, 2020 •

edited

Loading

rjmholt Apr 21, 2020

TylerLeonhardt Apr 21, 2020

SeeminglyScience Apr 21, 2020

TylerLeonhardt Apr 21, 2020

rjmholt Apr 21, 2020

TylerLeonhardt Apr 21, 2020

TylerLeonhardt Apr 21, 2020

TylerLeonhardt Apr 21, 2020

TylerLeonhardt commented Apr 23, 2020

TylerLeonhardt commented Apr 27, 2020

MSIH commented Jun 13, 2020

MSIH Jun 16, 2020

Update PackageManagement #1239

Update PackageManagement #1239

Conversation

TylerLeonhardt commented Mar 23, 2020 • edited Loading

rjmholt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TylerLeonhardt Apr 21, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TylerLeonhardt commented Apr 23, 2020

TylerLeonhardt commented Apr 27, 2020

MSIH commented Jun 13, 2020

Choose a reason for hiding this comment

TylerLeonhardt commented Mar 23, 2020 •

edited

Loading

TylerLeonhardt Apr 21, 2020 •

edited

Loading