Leverage internal HostUI for VT100 check #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tried this out on Windows Server 2012 R2 and no more escape sequences appear:
|
SeeminglyScience
approved these changes
Apr 20, 2020
|
Wait a tic, so you are completely disabling VT100 support in the PSIC? Or are you saying that we delegate this to |
@rkeithhill this one. |
You're thinking of conhost.exe. I'm referring to ConsoleHost.cs in the PowerShell code. |
rjmholt
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PowerShell/vscode-powershell#2637
Fixes PowerShell/vscode-powershell#2640
A user can be using PowerShell 5.1 or greater on Windows Server 2012 R2.
We can leverage the internal host to get the value already computed by ConsoleHost.
I haven't tested this... I'd need to break out a 2012 R2 VM 😢