Refactor GetCommandHandler to not use dynamic #1268
Conversation
| commandList.Add(new PSCommandMessage | ||
| { | ||
| Name = command.Name, | ||
| ModuleName = command.ModuleName, | ||
| Parameters = command.Parameters, | ||
| ParameterSets = command.ParameterSets, | ||
| DefaultParameterSet = command.DefaultParameterSet |
There was a problem hiding this comment.
What's the story on needing the for-loop instead of this?
There was a problem hiding this comment.
CommandInfo's only have:
no DefaultParameterSet
There was a problem hiding this comment.
DefaultParameterSet's might only exist on CmdletInfo and FunctionInfo.. so I could special case those types... but there are a lot of *Info's
There was a problem hiding this comment.
Given that we're probably mostly going to deal with those types, I think that would make sense as an optimisation
There was a problem hiding this comment.
added a switch but still kept the loop for everything else (which atm is just ExternalScript).
| // Some info objects have a quicker way to get the DefaultParameterSet. These | ||
| // are also the most likely to show up so win-win. | ||
| string defaultParameterSet = null; | ||
| switch (command) |
There was a problem hiding this comment.
I just wanna use the new pattern matching switch but it says it's still "preview" 😭
|
Issues
======
- Added 2
Complexity increasing per file
==============================
- src/PowerShellEditorServices/Services/PowerShellContext/Handlers/GetCommandHandler.cs 3
See the complete overview on Codacy |
| // Some info objects have a quicker way to get the DefaultParameterSet. These | ||
| // are also the most likely to show up so win-win. | ||
| string defaultParameterSet = null; | ||
| switch (command) |
There was a problem hiding this comment.
| // Some info objects have a quicker way to get the DefaultParameterSet. These | ||
| // are also the most likely to show up so win-win. | ||
| string defaultParameterSet = null; | ||
| switch (command) |
There was a problem hiding this comment.
Refactor GetCommandHandler to not use dynamic.
This includes a test change that was needed because a PowerShell type didn't serialize correctly.
cc @corbob