move to omnisharp 0.17.0 #1283
Merged
move to omnisharp 0.17.0 #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
changed the title
|
Issues
======
- Added 3
Complexity increasing per file
==============================
- src/PowerShellEditorServices/Services/Analysis/AnalysisService.cs 2
- src/PowerShellEditorServices/Server/PsesLanguageServer.cs 1
- src/PowerShellEditorServices/Services/TextDocument/Handlers/CodeActionHandler.cs 7
Clones removed
==============
+ src/PowerShellEditorServices/Services/TextDocument/Handlers/DefinitionHandler.cs -1
+ src/PowerShellEditorServices/Services/TextDocument/Handlers/ReferencesHandler.cs -1
See the complete overview on Codacy |
TylerLeonhardt
commented
May 5, 2020
TylerLeonhardt
commented
May 5, 2020
TylerLeonhardt
commented
May 5, 2020
rjmholt
approved these changes
May 5, 2020
bergmeister
reviewed
May 26, 2020
| @@ -39,7 +39,7 @@ | |||
| <PackageReference Include="Microsoft.CSharp" Version="4.7.0" /> | |||
| <PackageReference Include="Microsoft.Extensions.FileSystemGlobbing" Version="3.1.3" /> | |||
| <PackageReference Include="Microsoft.Extensions.Logging" Version="3.1.3" /> | |||
| <PackageReference Include="OmniSharp.Extensions.LanguageServer" Version="0.16.0" /> | |||
| <PackageReference Include="OmniSharp.Extensions.LanguageServer" Version="0.17.0-*" /> | |||
There was a problem hiding this comment.
@TylerLeonhardt @rjmholt
This change broke the build in the last view days because on that myget server, they also publish packages that end with 0.17.0-pullrequest, which are being used. We should use something like 0.17.0-alpha* instead.
I opened PR #1299 to fix that and adapt to the new breaking changes in its newer versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main changes:
Uri->DocumentUrilongs ->intsand requests now have a
.Returning<resultType>(CancellationToken)and.ReturningNull(CancellationToken)instead of doing likeSendRequest<Params,Result>(....)Just waiting on OmniSharp/csharp-language-server-protocol#237done