New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdio should only launch language service not debug #710

Merged

TylerLeonhardt merged 1 commit into master from stdio-fix

Jul 25, 2018

Member

TylerLeonhardt commented Jul 25, 2018

if both are launched - then the text is split between the language and debug service - aka PSES just doesn't work.

This should be the final PR in "fixing stdio"


          stdio should only launch language service not debug

565bcc0

TylerLeonhardt requested a review from rjmholt as a code owner

July 25, 2018 06:33

TylerLeonhardt requested review from rkeithhill and SeeminglyScience

July 25, 2018 06:33

rkeithhill approved these changes

View reviewed changes

Contributor

rkeithhill left a comment

Other than the whacked build hang, this LGTM

TylerLeonhardt merged commit 87376c3 into master

TylerLeonhardt deleted the stdio-fix branch

July 25, 2018 14:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet