workaround to support inmemory:// #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
requested review from
rjmholt and
SeeminglyScience
as code owners
rkeithhill
reviewed
Jul 26, 2018
There was a problem hiding this comment.
Looking at this:
https://github.com/PowerShell/PowerShellEditorServices/search?l=C%23&q=untitled
Should we add a test to WorkspaceTests? Also, what about the DebugAdapter? Does it need to be updated or is debugging not a valid scenario for this use case?
|
@rkeithhill the debug scenario doesn't really apply here since Monaco can only listen to one service over stdio. The debug service isn't running. That said, great find on the tests, I'll add some! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't the most elegant solution but it does the trick. I don't think we'll run into many (if not any) more Uri schemes we care about. When we run into another, then we can probably discuss a better solution.
Let me know if you feel differently.