Win7 OSArchitecture crash workaround #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
requested review from
TylerLeonhardt,
rkeithhill and
SeeminglyScience
| @@ -493,6 +495,16 @@ private IServerListener CreateServiceListener(MessageProtocolType protocol, Edit | |||
| } | |||
| } | |||
|
|
|||
| private static string GetOSArchitecture() | |||
| { | |||
| if (IntPtr.Size == 8) | |||
There was a problem hiding this comment.
This will tell you the architecture of the current process, so this could be a x86 process running on a x64 OS.
Does Environment.Is64BitOperatingSystem work for us?
There was a problem hiding this comment.
Yeah that's a much better way
…e in win7 on .NET Framework
rjmholt
force-pushed
the
win7-osarch-workaround
branch
from
4494bb4 to
e627ad6
Compare
TylerLeonhardt
approved these changes
Dec 7, 2018
|
This doesn't work yet. Looking into it |
|
Ok, I've fixed my foolishness |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids calling the System.Runtime.InteropServices.RuntimeInformation API that crashes in Win7.
See PowerShell/vscode-powershell#1633.