Fix NullRefEx bug when accessing scriptFile.ReferencedFiles #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkeithhill
requested review from
TylerLeonhardt,
rjmholt and
SeeminglyScience
rkeithhill
force-pushed
the
rkeithhill/fix-refdfiles-nre
branch
from
d4076b8 to
3fdb5e1
Compare
…ns because the ScriptFile ctor does not initialize all itspublic props. I added initialization for the other public propsexcept for the ScriptAst prop. I don't see an empty Ast. Perhaps nullis OK for this prop?This address vscode-powershell bug https://github.com/PowerShell/vscode-powershell/issues/1675Also, for the 2.0.0 branch, we should see if we can use Array.Empty<>()for initialization. It isn't availble to net45x. :-(
rkeithhill
force-pushed
the
rkeithhill/fix-refdfiles-nre
branch
from
3fdb5e1 to
bd01d79
Compare
|
@rkeithhill could we possibly add a test for this? That maybe just creates a simple ScriptFile and checks its props? Or something a little further up the stack that creates a new ScriptFile |
|
Working on it. Man it sure would be nice if the xUnit / VS Test Explorer integration weren't so crappy. Can't seem to step into tests and test output won't show me line numbers. Sigh... |
TylerLeonhardt
approved these changes
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens because the ScriptFile ctor does not initialize all its
public props. I added initialization for the other public props
except for the ScriptAst prop. I don't see an empty Ast. Perhaps null
is OK for this prop?
This address vscode-powershell bug PowerShell/vscode-powershell#1675
No real need for ScriptTokens to have a backing field. Make it auto like the other props.
Also, for the 2.0.0 branch, we should see if we can use Array.Empty<>()
for initialization. It isn't availble to net45x. :-(