Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XUnit warnings that better assertion operators should be used. #858

Merged
merged 3 commits into from
Jan 30, 2019
Merged

Fix XUnit warnings that better assertion operators should be used. #858

merged 3 commits into from
Jan 30, 2019

Conversation

bergmeister
Copy link
Contributor

This also cleans up the build log

@bergmeister bergmeister requested a review from rjmholt as a code owner January 22, 2019 23:07
TylerLeonhardt
TylerLeonhardt approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rjmholt
rjmholt approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bergmeister!

@rjmholt rjmholt merged commit f853185 into PowerShell:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmholt rjmholt rjmholt approved these changes

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bergmeister @TylerLeonhardt @rjmholt