Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Get-PsesRpcNotificationMessage/MessageResponseTimes to allow filtering by message name #889

Merged
merged 3 commits into from
Mar 23, 2019

Conversation

rkeithhill
Copy link
Contributor

This is more of an FYI on updates to this log file analysis module.

@rkeithhill rkeithhill changed the title Ehanche Get-PsesRpcNotificationMessage/MessageResponseTimes to allow filtering by message name Enhance Get-PsesRpcNotificationMessage/MessageResponseTimes to allow filtering by message name Mar 23, 2019
@rkeithhill
Copy link
Contributor Author

BTW log analysis shows significant perf improvement from before PSSA 1.18 (1.17):

> Get-PsesRpcMessageResponseTime $logBefore | Sort ElapsedMilliseconds -Descending | Select-Object -First 10

 Index Timestamp                  TID  Elapsed (mS) Message
 ----- ---------                  ---  ------------ -------
   428 2019-03-23 16:50:51.037     17         39642 Name: textDocument/signatureHelp Id: 47, DataSize: 171
   615 2019-03-23 16:51:18.116     17         26648 Name: textDocument/rangeFormatting Id: 73, DataSize: 77561
   133 2019-03-23 16:50:08.234     17          2866 Name: textDocument/signatureHelp Id: 15, DataSize: 171
   387 2019-03-23 16:50:11.114     17          1166 Name: codeLens/resolve Id: 42, DataSize: 21924
   793 2019-03-23 16:51:18.944     17           372 Name: textDocument/definition Id: 96, DataSize: 72
   753 2019-03-23 16:51:18.503     17           273 Name: codeLens/resolve Id: 91, DataSize: 21924
    66 2019-03-23 16:50:05.041     17           261 Name: textDocument/documentSymbol Id: 6, DataSize: 17466
   877 2019-03-23 16:51:19.829     17           214 Name: codeLens/resolve Id: 103, DataSize: 21925
   957 2019-03-23 16:51:22.978     17           211 Name: codeLens/resolve Id: 110, DataSize: 21925
   508 2019-03-23 16:50:51.278     17           192 Name: codeLens/resolve Id: 54, DataSize: 21924

And after installing 1.18 (same file - InvokePlaster.ps1 with some editing and full doc formatting):

Get-PsesRpcMessageResponseTime $logAfter | Sort ElapsedMilliseconds -Descending | Select-Object -First 10

 Index Timestamp                  TID  Elapsed (mS) Message
 ----- ---------                  ---  ------------ -------
   145 2019-03-23 16:57:43.380     17          2869 Name: textDocument/signatureHelp Id: 15, DataSize: 171
   309 2019-03-23 16:57:45.627     17           915 Name: codeLens/resolve Id: 27, DataSize: 21924
   872 2019-03-23 16:58:20.685     17           797 Name: textDocument/rangeFormatting Id: 90, DataSize: 77084
  1033 2019-03-23 16:58:35.523     17           523 Name: textDocument/rangeFormatting Id: 104, DataSize: 77085
  1060 2019-03-23 16:58:39.144     17           347 Name: textDocument/hover Id: 109, DataSize: 590
    66 2019-03-23 16:57:39.939     17           264 Name: textDocument/documentSymbol Id: 6, DataSize: 17466
   159 2019-03-23 16:57:43.836     17           261 Name: textDocument/completion Id: 17, DataSize: 20171
   703 2019-03-23 16:58:11.802     17           233 Name: textDocument/definition Id: 75, DataSize: 72
   391 2019-03-23 16:58:05.558     17           225 Name: codeLens/resolve Id: 34, DataSize: 21924
   662 2019-03-23 16:58:06.696     17           206 Name: codeLens/resolve Id: 70, DataSize: 21924

cc @bergmeister

@rkeithhill rkeithhill merged commit 8730ea4 into master Mar 23, 2019
@rkeithhill rkeithhill deleted the rkeithhill/enh-get-pses-rpc-response-times branch March 23, 2019 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant