Fix silent failure by using Id for dictionary since multiple pages could have the same title #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
approved these changes
Apr 25, 2019
|
LGTM but the PR title could say something about the bug that it fixes on a higher level, which is the purpose of the PR |
TylerLeonhardt
changed the title
TylerLeonhardt
added a commit
that referenced
this pull request
Apr 26, 2019
…uld have the same title (#947) * Use Id for dictionary since multiple pages could have the same title * codacy got me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to be clear that this is only fixing a bug where:
the first time would be an object we expect, the second time,
$vwould benullbecause.Addthrows if the key already exists. After switching it to useId, there should be no collision.Ideally this feature could use a
Get-VSCodeHtmlContentViewthat pulls from that Dictionary... but that's out of scope.