Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defend against crash when no PSSA #974

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Defend against crash when no PSSA #974

merged 1 commit into from
Jun 25, 2019

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Jun 7, 2019

Fixes PowerShell/vscode-powershell#2007.

Formatting doesn't check to see if the AnalysisService is null before a method invocation.

SeeminglyScience
SeeminglyScience approved these changes Jun 8, 2019
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two questions (in one comment)

src/PowerShellEditorServices.Protocol/Server/LanguageServer.cs Show resolved Hide resolved
rkeithhill
rkeithhill approved these changes Jun 8, 2019
View reviewed changes
Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerLeonhardt TylerLeonhardt merged commit 5f9d89a into PowerShell:master Jun 25, 2019
@rjmholt rjmholt mentioned this pull request Jul 24, 2019
Merged
rjmholt added a commit that referenced this pull request Jul 27, 2019
@rjmholt
Backport #974 (#994)
4518fa1 
* Backport 5f9d89a

* Fix async abuse

* Add semicolon
@rjmholt rjmholt deleted the format-analysis-crash branch December 11, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

@rkeithhill rkeithhill rkeithhill approved these changes

@TylerLeonhardt TylerLeonhardt Awaiting requested review from TylerLeonhardt

Assignees
No one assigned
Labels
Area-Script Analysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Powershell session terminates by "Format Document" on Windows 2008 R2
4 participants
@rjmholt @rkeithhill @SeeminglyScience @TylerLeonhardt