add motw to scp and sftp #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulHigin
suggested changes
Jul 25, 2022
PaulHigin
suggested changes
Jul 26, 2022
PaulHigin
suggested changes
Aug 4, 2022
PaulHigin
suggested changes
Aug 18, 2022
Co-authored-by: Paul Higinbotham <paulhi@microsoft.com>
PaulHigin
suggested changes
Aug 22, 2022
PaulHigin
suggested changes
Aug 22, 2022
3 tasks
3 tasks
rgl
reviewed
Dec 17, 2022
| @@ -2074,6 +2083,12 @@ sink(int argc, char **argv, const char *src) | |||
| omode = mode; | |||
| mode |= S_IWUSR; | |||
| #ifdef WINDOWS | |||
| if (add_mark_of_web(np) == -1) { | |||
| if (verbose_mode) { | |||
| note_err("%s: add_mark_of_web failed\n", np); | |||
There was a problem hiding this comment.
why is this message handled differently than in sftp-client.c/sftp-server.c (where is uses debug instead of note_err)?
rgl
reviewed
Dec 17, 2022
|
|
||
| int ofd, status = 0; | ||
| char* zoneIdentifierStr = NULL; | ||
| size_t zoneIndentifierLen = strlen("[ZoneTransfer]\nZoneId=") + 1 + 1; |
There was a problem hiding this comment.
there's a typo in zoneIndentifierLen, it should be zoneIdentifierLen.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
address PowerShell/Win32-OpenSSH#1964
PR Context
Add mark of the web for files transferred via scp & sftp to address bypassing protected view for Office files. For scp and the sftp server, if adding the mark of the web fails, file transfer will fail. For the sftp client, if adding the mark of the web fails, the transferred file will be removed.