Add buttons for moving the terminal around. (#2704)

* Add buttons for moving the terminal around.

* Add button visibility options.

* Simplified button visibility options.

package.json

@@ -265,6 +265,33 @@
         "command": "PowerShell.InvokeRegisteredEditorCommand",
         "title": "Invoke Registered Editor Command",
         "category": "PowerShell"
+      },
+      {
+        "command": "workbench.action.closePanel",
+        "title": "Close panel",
+        "category": "PowerShell",
+        "icon": {
+          "light": "resources/light/ClosePanel.svg",
+          "dark": "resources/dark/ClosePanel.svg"
+        }
+      },
+      {
+        "command": "workbench.action.positionPanelLeft",
+        "title": "Move panel left",
+        "category": "PowerShell",
+        "icon": {
+          "light": "resources/light/MovePanelLeft.svg",
+          "dark": "resources/dark/MovePanelLeft.svg"
+        }
+      },
+      {
+        "command": "workbench.action.positionPanelBottom",
+        "title": "Move panel to bottom",
+        "category": "PowerShell",
+        "icon": {
+          "light": "resources/light/MovePanelBottom.svg",
+          "dark": "resources/dark/MovePanelBottom.svg"
+        }
       }
     ],
     "menus": {
@@ -306,12 +333,27 @@
       ],
       "editor/title": [
         {
-          "when": "editorLangId == powershell",
+          "when": "editorLangId == powershell && config.powershell.buttons.showPanelMovementButtons",
+          "command": "workbench.action.positionPanelBottom",
+          "group": "navigation@97"
+        },
+        {
+          "when": "editorLangId == powershell && config.powershell.buttons.showPanelMovementButtons",
+          "command": "workbench.action.positionPanelLeft",
+          "group": "navigation@98"
+        },
+        {
+          "when": "editorLangId == powershell && config.powershell.buttons.showPanelMovementButtons",
+          "command": "workbench.action.closePanel",
+          "group": "navigation@99"
+        },
+        {
+          "when": "editorLangId == powershell && config.powershell.buttons.showRunButtons",
           "command": "workbench.action.debug.start",
           "group": "navigation@100"
         },
         {
-          "when": "editorLangId == powershell",
+          "when": "editorLangId == powershell && config.powershell.buttons.showRunButtons",
           "command": "PowerShell.RunSelection",
           "group": "navigation@101"
         }
@@ -800,6 +842,16 @@
           ],
           "default": "Diagnostic",
           "description": "Defines the verbosity of output to be used when debugging a test or a block. For Pester 5 and newer the default value Diagnostic will print additional information about discovery, skipped and filtered tests, mocking and more."
+        },
+        "powershell.buttons.showRunButtons": {
+          "type": "boolean",
+          "default": true,
+          "description": "Show the Run and Run Selection buttons in the editor titlebar."
+        },
+        "powershell.buttons.showPanelMovementButtons": {
+          "type": "boolean",
+          "default": false,
+          "description": "Show buttons in the editor titlebar for moving the panel around."
         }
       }
     },

src/features/ISECompatibility.ts

@@ -24,6 +24,7 @@ export class ISECompatibilityFeature implements IFeature {
         { path: "powershell.integratedConsole", name: "focusConsoleOnExecute", value: false },
         { path: "files", name: "defaultLanguage", value: "powershell" },
         { path: "workbench", name: "colorTheme", value: "PowerShell ISE" },
+        { path: "powershell.buttons", name: "showPanelMovementButtons", value: true }
     ];
     private iseCommandRegistration: vscode.Disposable;
     private defaultCommandRegistration: vscode.Disposable;

src/settings.ts

@@ -100,6 +100,7 @@ export interface ISettings {
     bugReporting?: IBugReportingSettings;
     sideBar?: ISideBarSettings;
     pester?: IPesterSettings;
+    buttons?: IButtonSettings;
 }
 
 export interface IStartAsLoginShellSettings {
@@ -125,6 +126,11 @@ export interface IPesterSettings {
     debugOutputVerbosity?: string;
 }
 
+export interface IButtonSettings {
+    showRunButtons?: boolean;
+    showPanelMovementButtons?: boolean;
+}
+
 export function load(): ISettings {
     const configuration: vscode.WorkspaceConfiguration =
         vscode.workspace.getConfiguration(
@@ -192,6 +198,11 @@ export function load(): ISettings {
         CommandExplorerVisibility: true,
     };
 
+    const defaultButtonSettings: IButtonSettings = {
+        showRunButtons: true,
+        showPanelMovementButtons: false
+    };
+
     const defaultPesterSettings: IPesterSettings = {
         useLegacyCodeLens: true,
         outputVerbosity: "FromPreference",
@@ -237,6 +248,8 @@ export function load(): ISettings {
             configuration.get<ISideBarSettings>("sideBar", defaultSideBarSettings),
         pester:
             configuration.get<IPesterSettings>("pester", defaultPesterSettings),
+        buttons:
+            configuration.get<IButtonSettings>("buttons", defaultButtonSettings),
         startAsLoginShell:
             // tslint:disable-next-line
             // We follow the same convention as VS Code - https://github.com/microsoft/vscode/blob/ff00badd955d6cfcb8eab5f25f3edc86b762f49f/src/vs/workbench/contrib/terminal/browser/terminal.contribution.ts#L105-L107