Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snippet "Function advanced" #1177

Closed
timoline opened this issue Jan 27, 2018 · 8 comments
Closed

snippet "Function advanced" #1177

timoline opened this issue Jan 27, 2018 · 8 comments
Labels
Area-Snippets Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.

Comments

@timoline
Copy link

Can you add a snippet for an advanced function (just like in ISE) ?
thanks

@timoline
Copy link
Author

timoline commented Jan 27, 2018

Ok found it (but not very logical to me)

There is a snippet for advanced functions: cmdlet. There are more "example" like snippets that are prefixed ex- for DSC and advanced functions e.g. ex-cmdlet.

Why not just when typing function or function-advanced ?

@TylerLeonhardt
Copy link
Member

That's a reasonable ask and should be just a config change. Did you want to try and contribute it?

@TylerLeonhardt TylerLeonhardt added Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs. Area-Snippets labels Jan 29, 2018
@timoline
Copy link
Author

If you don't mind, I leave it uo to the pros...
I'm just a customer ;-)

@TylerLeonhardt
Copy link
Member

Sounds good! We'll get to it as soon as we can. It would be a simple change in this file:
https://github.com/PowerShell/vscode-powershell/blob/master/snippets/PowerShell.json#L515

in case you change your mind :)

@rkeithhill
Copy link
Contributor

FWIW, the ex- snippets are more, um, opinionated perhaps. For the "standard" snippets like for for, foreach, etc we try to remain very vanilla. One person's treasure is another person's garbage (and vice-versa). :-)

@Benny1007
Copy link
Contributor

Hey @tylerl0706 I'd like to submit a PR for this if I may

Benny1007 added a commit to Benny1007/vscode-powershell that referenced this issue Feb 1, 2018
@Benny1007
Copy link
Contributor

PR submitted
#1182

first PR so hope I did everything right! grateful for any guidance :)

@TylerLeonhardt
Copy link
Member

Thanks @Ben-Shirley! Let me take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Snippets Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.
Projects
None yet
Development

No branches or pull requests

4 participants