-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invoking "Go to Definition" in an untitled script causes a host crash #645
Labels
Milestone
Comments
daviwil
changed the title
Console Crash
Invoking "Go to Definition" in an untitled script causes a host crash
Apr 4, 2017
Looks like we're not handling untitled file paths in code navigation actions. Here is the relevant part of the logs:
|
daviwil
modified the milestones:
Next Patch Update,
Next Feature Update,
April 2017,
0.12.2
Apr 4, 2017
daviwil
added a commit
to daviwil/PowerShellEditorServices
that referenced
this issue
Apr 7, 2017
This change fixes a host crash which occurs when the user tries to perform a symbol operation (like Go to Definition or Find References) in an untitled script file. The fix is to not try and convert an untitled file's path to a Uri. Resolves PowerShell/vscode-powershell#645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
System Details
Win 8.1 Pro
1.10.2
8076a19fdcab7e1fc1707952d652f0bb6c6db331
christian-kohler.path-intellisense@1.2.0
emilast.LogFileHighlighter@1.1.1
ivangabriele.vscode-tfs@0.6.0
ms-vscode.PowerShell@0.11.0
ms-vsts.team@1.115.0
$PSVersionTable
:PSVersion 5.0.10586.117
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
BuildVersion 10.0.10586.117
CLRVersion 4.0.30319.42000
WSManStackVersion 3.0
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1
Issue Description
The application reports that the PowerShell console has crashed and prompts me with a Yes | No | Close for restarting it. The terminal is still functional after hitting close. I'm not using the terminal before the crash is reported.
Attached Logs
Logs being sent to David.
The text was updated successfully, but these errors were encountered: