Update to handle PS Core binary name change #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix PowerShell#1064 Also fixes case where the powerShellExePath setting is no longer valid. This happens when a Windows users installs an updated pre-release version of PS Core. That uninstalls previous versions.
daviwil
reviewed
Oct 26, 2017
src/platform.ts
Outdated
| @@ -73,9 +73,15 @@ export function getDefaultPowerShellPath( | |||
| } | |||
| else if (platformDetails.operatingSystem == OperatingSystem.MacOS) { | |||
| powerShellExePath = "/usr/local/bin/powershell"; | |||
| if (fs.existsSync("/usr/loca/bin/pwsh")) { | |||
There was a problem hiding this comment.
Missed an 'l' in 'local' in the path
daviwil
approved these changes
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1064
Also fixes case where the powerShellExePath setting is no longer valid. This happens when a Windows users installs an updated pre-release version of PS Core which uninstalls the previous version.