Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defend HelpCompletion from null message from VSCode #1236

Merged
merged 3 commits into from
Mar 27, 2018
Merged

Defend HelpCompletion from null message from VSCode #1236

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5db096d
Defend HelpCompletion from null message from VSCode
rjmholt Mar 21, 2018
c0d0386
Null check changeEvent.contentChanges[0] and log bad messages
rjmholt Mar 22, 2018
034369f
Move contentChanges length check below null chk
rkeithhill Mar 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/features/HelpCompletion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ export class HelpCompletionFeature implements IFeature {
}

public onEvent(changeEvent: TextDocumentChangeEvent): void {
if (!changeEvent) {
return;
}

this.helpCompletionProvider.updateState(
changeEvent.document,
changeEvent.contentChanges[0].text,
Copy link
Contributor

@rkeithhill rkeithhill Mar 22, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to check contentChanges[0] for undefined. If changeEvent itself was getting thru as undefined then we should have gotten an error on changeEvent.document first.

Expand Down