Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Columns, Improved readability for ToC. #1307

Merged
merged 3 commits into from
May 2, 2018
Merged

Added Columns, Improved readability for ToC. #1307

merged 3 commits into from
May 2, 2018

Conversation

st0le
Copy link
Contributor

@st0le st0le commented May 1, 2018

Made the Table of contents split into 2 columns for better formatting and also fixed a link.

@msftclas
Copy link

msftclas commented May 1, 2018

CLA assistant check
All CLA requirements met.

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 little comment, otherwise LGTM! Thank you so much for doing this it looks SO much nicer 😁

|:------------------|
| [PSCustomObject](#pscustomobject): _A simple PSCustomObject_ |
| Snippet Name | Description |
|--------- | ---------|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also one more change to this a little bit higher up on line 305. Can you also fix that one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that. I've fixed it.

Fixed the missed instances.
@corbob
Copy link
Contributor

corbob commented May 2, 2018

I like! This is what I couldn't come up with. I was trying to keep the title as a single cell which GitHub doesn't support. Split as a table works better IMHO. 👍

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much cleaner 😍 LGTM! Thanks for contributing 🙂

@TylerLeonhardt TylerLeonhardt merged commit c1b643e into PowerShell:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants