(maint) Add visual ruler for line length #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
force-pushed
the
add-visual-ruler
branch
from
d661b28 to
cb1269c
Compare
|
Hrmm odd. Appveyor ignored my |
rkeithhill
approved these changes
Jun 11, 2018
|
Oh, one minor nit, would you mind moving this setting up by the other |
rjmholt
approved these changes
Jun 11, 2018
|
Okay...so do I move it or not? got a +1 for both sides ... |
|
Yes, please move it up to line 5 and then I'll merge this PR. Thanks! |
Previously it was a little difficult to know when your editing would exceed the 120 line length limit. This commit modifies the project settings to add a simple visual ruler at the 120 char limit. [skip ci]
glennsarti
force-pushed
the
add-visual-ruler
branch
from
cb1269c to
9c343a6
Compare
|
Done. Also added an EOF line feed as it was missing. |
|
Sorry I meant I'm in favour of @rkeithhill's proposed changes |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Previously it was a little difficult to know when your editing would exceed
the 120 line length limit. This commit modifies the project settings to add
a simple visual ruler at the 120 char limit.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready