Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the extension's log level based on settings value #1412

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

rkeithhill
Copy link
Contributor

@rkeithhill rkeithhill commented Jul 9, 2018

PR Summary

We set the log level in the Logger class during construction but then never seem to set it again. This PR loads the settings and sets the desired log level right after the logger is constructed and before all the features are initialized. This is important as some of the features want to do diagnostic logging. Without this change, we never see those diagnostic messages in the log.

There is some risk in moving the Settings.load() earlier in the startup process but I think the Settings class is pretty much a stand-alone, non-Feature based class.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rkeithhill rkeithhill closed this Jul 10, 2018
@rkeithhill rkeithhill reopened this Jul 10, 2018
@rkeithhill rkeithhill merged commit 77da510 into master Jul 10, 2018
@rkeithhill rkeithhill deleted the rkeithhill/fix-extension-logging branch July 10, 2018 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants