(GH-1458) Remove region folding from non-region areas #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously all of the folding ranges were either Region or Comment, however this is confusing e.g. a Here String is neither a region or a comment. The VS Code API does state that the range kind property is optional. This commit changes the range kind for braces, parentheses and here strings to be null, that is, neither a region or comment range. This makes editor commands like 'Fold All Regions' behave as a user expects.
glennsarti
force-pushed
the
gh-1458-folding-kind-optional
branch
from
83dfaea to
faf5f70
Compare
glennsarti
changed the title
TylerLeonhardt
approved these changes
Aug 6, 2018
rjmholt
approved these changes
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Previously all of the folding ranges were either Region or Comment, however this
is confusing e.g. a Here String is neither a region or a comment. The VS Code
API does state that the range kind property is optional. This commit changes
the range kind for braces, parentheses and here strings to be null, that is,
neither a region or comment range. This makes editor commands like
'Fold All Regions' behave as a user expects.
Fixes #1458
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready