Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change resourceLangId to editorLangId Fixes 1473 #1475

Merged
merged 1 commit into from
Aug 10, 2018
Merged

Change resourceLangId to editorLangId Fixes 1473 #1475

merged 1 commit into from
Aug 10, 2018

Conversation

corbob
Copy link
Contributor

@corbob corbob commented Aug 10, 2018

PR Summary

Right Click will now work with a unsaved file, or a file with non-standard PowerShell extension that is manually set to PowerShell Language.

Uses editorLangId instead of resourceLangId as editorLangId pulls from the editor's set language and not the file's extension: https://code.visualstudio.com/docs/getstarted/keybindings

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not work in progress

Right Click will now work with a unsaved file, or a file with non-standard PowerShell extension that is manually set to PowerShell Language
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niceeeee LGTM!

Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @corbob!

@rjmholt rjmholt merged commit 9d04a64 into PowerShell:master Aug 10, 2018
@corbob corbob deleted the issue1473 branch January 17, 2019 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants