{WIP} (GH-1514) Show last line folding #1551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ult VSCode Changes the default to true Adds tests
|
Example alternate PR for #1546 |
3 tasks
|
@rjmholt I wasn't keen on adding a devDependency for a Mocha mocking framework so I used a class wrapper for the folding provider instead. Maybe something consider in the medium term on how to mock values/methods for this project? |
|
Closing in preference to #1557 |
|
@glennsarti I think new dependencies to reduce friction on testing seems pretty justified. We can discuss with @tylerl0706 and @rkeithhill. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Alternative implementation of #1514
PR Checklist
DO NOT MERGE