Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first steps to ISE compatibility doc #1632

Merged
merged 15 commits into from
Dec 12, 2018

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Dec 6, 2018

PR Summary

Adds a document summarising ways to make VSCode feel more like the ISE.

While the PR is open, feel free to suggest additions!

@rjmholt
Copy link
Contributor Author

rjmholt commented Dec 6, 2018

Also pinging @corbob and @glennsarti

@glennsarti
Copy link
Contributor

Not for me. I never used the ISE. Primal Script and then VSCode :-)

@rjmholt
Copy link
Contributor Author

rjmholt commented Dec 6, 2018

We should also include some stuff about setting up debug configurations maybe

@TylerLeonhardt
Copy link
Member

Especially the interactive debugging experience.

Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A couple optional wording suggestions

docs/ise_compatibility.md Outdated Show resolved Hide resolved
docs/ise_compatibility.md Outdated Show resolved Hide resolved
docs/ise_compatibility.md Outdated Show resolved Hide resolved
"workbench.colorTheme": "PowerShell ISE"
```

## Show-Command
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Show-Command
## Command explorer

If it doesn't actually replace Show-Command this title would be confusing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intent is for the titles to be keyed to ISE vocabulary as a lookup for new concepts, but I can change

docs/ise_compatibility.md Outdated Show resolved Hide resolved
SeeminglyScience and others added 4 commits December 6, 2018 07:09
Co-Authored-By: rjmholt <rjmholt@gmail.com>
Co-Authored-By: rjmholt <rjmholt@gmail.com>
Co-Authored-By: rjmholt <rjmholt@gmail.com>
@rjmholt rjmholt closed this Dec 12, 2018
@rjmholt rjmholt deleted the ise-compat-docs branch December 12, 2018 06:04
@rjmholt rjmholt restored the ise-compat-docs branch December 12, 2018 06:04
@rjmholt rjmholt reopened this Dec 12, 2018
docs/ise_compatibility.md Outdated Show resolved Hide resolved
| ---------------- | ----------- | -------------- |
| Interrupt and break debugger | <kbd>Ctrl</kbd>+<kbd>B</kbd> | <kbd>F6</kbd> |
| Execute current line/highlighted text | <kbd>F8</kbd> | <kbd>F8</kbd> |
| List available snippets | | <kbd>Ctrl</kbd>+<kbd>Alt</kbd>+<kbd>J</kbd> |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I THINK this is Ctrl+J in the ISE.

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great place to start 😊 LGTM

@rjmholt rjmholt merged commit 48df606 into PowerShell:master Dec 12, 2018
@rjmholt rjmholt deleted the ise-compat-docs branch December 12, 2018 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants