Escape "-Command" arguments to prevent Terminal API failure #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes: https://github.com/codercom/bugs/issues/270. On Ubuntu 16.04 containers, the Terminal API fails to start the pwsh executable with any "-Command" arguments. This appears to be due to unescaped single quotes within the argument list.
|
Tested this out on Windows which uses PowerShell instead of bash as the driver and unfortunately, this change won't work there. It simply prints out the full command which could be due to the use of I tried to leverage PowerShell's Ill have to investigate further. |
7 tasks
|
I've got a possible fix opened in #1774 so I'll close this in favor of that. |
|
Sounds good!
…On Tue, Feb 26, 2019, 12:27 PM Tyler James Leonhardt < ***@***.***> wrote:
I've got a possible fix opened in #1774
<#1774> so I'll close
this in favor of that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1772 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACVGmRUGQANx0cNwFElx0FL8k342MJ-jks5vRXyIgaJpZM4bJ9Ud>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/codercom/bugs/issues/270.
PR Summary
On Ubuntu 16.04 containers, the Terminal API fails to start the pwsh executable with any "-Command" arguments. This appears to be due to unescaped single quotes within the argument list.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.PR has tests(NA)WIP:to the beginning of the title and remove the prefix when the PR is ready