Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PSReadLine default on Windows #1794

Merged
merged 2 commits into from
Mar 20, 2019

Conversation

TylerLeonhardt
Copy link
Member

PR Summary

Make PSReadLine default on Windows because:

  1. people don't remember do add it
  2. we need more feedback

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@rkeithhill
Copy link
Contributor

I think having this feature on by default is the way to go. However, will we have a way to "disable" the feature if necessary? I know I've run into the endless prompt loop issue enough that I disabled the feature.

@TylerLeonhardt
Copy link
Member Author

TylerLeonhardt commented Mar 16, 2019

@rkeithhill yeah you would just do:

powershell.developer.featureFlags: []

@Jaykul
Copy link

Jaykul commented Mar 16, 2019

You added PRSL and didn't make it the default? 👀

@TylerLeonhardt TylerLeonhardt merged commit b4d99b7 into PowerShell:master Mar 20, 2019
@TylerLeonhardt TylerLeonhardt deleted the psrl-default-windows branch March 20, 2019 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants