Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ADS insiders gallery file to update script #2038

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Add ADS insiders gallery file to update script #2038

merged 1 commit into from
Jun 25, 2019

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Jun 19, 2019 •
edited
Loading

PR Summary

Creates a PR like microsoft/azuredatastudio#6109.

This update adds the insiders gallery file

@rjmholt rjmholt requested a review from TylerLeonhardt June 19, 2019 22:07
@TylerLeonhardt
Copy link
Member

Any reason the generated PR has an extra merge commit instead of rebasing?

@TylerLeonhardt
Copy link
Member

LGTM

@rjmholt
Copy link
Contributor Author

rjmholt commented Jun 20, 2019

Any reason the generated PR has an extra merge commit instead of rebasing?

It had conflict in it that I fixed in GitHub, which generates a merge commit

@TylerLeonhardt TylerLeonhardt merged commit c9950b0 into PowerShell:master Jun 25, 2019
@rjmholt rjmholt deleted the ads-update-insiders branch December 11, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjmholt @TylerLeonhardt