Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

everything needed so far for omnisharp-lsp #2118

Merged
merged 1 commit into from
Aug 5, 2019
Merged

everything needed so far for omnisharp-lsp #2118

merged 1 commit into from
Aug 5, 2019

Conversation

TylerLeonhardt
Copy link
Member

This includes:

  • changing casing of codelens
  • deletion of the "DocumentFormattingFeature" and having PSES directly handle formatting
  • making GetRunspaceRequestType send an object instead of just a string

@TylerLeonhardt TylerLeonhardt requested a review from rjmholt August 3, 2019 01:07
@TylerLeonhardt TylerLeonhardt changed the title everything needed so far everything needed so far for omnisharp-lsp Aug 3, 2019
@TylerLeonhardt TylerLeonhardt merged commit b2bb5e9 into PowerShell:omnisharp-lsp Aug 5, 2019
@TylerLeonhardt TylerLeonhardt deleted the omnisharp-lsp branch August 5, 2019 19:24
TylerLeonhardt added a commit that referenced this pull request Oct 1, 2019
@TylerLeonhardt
everything needed so far (#2118)
1ece440
TylerLeonhardt added a commit that referenced this pull request Oct 3, 2019
@TylerLeonhardt
everything needed so far (#2118)
8938691
TylerLeonhardt added a commit that referenced this pull request Oct 3, 2019
@TylerLeonhardt
Changes needed for Omnisharp migration of PowerShellEditorServices (#…
fcc13c1 
…2226)

* everything needed so far (#2118)

* Needed changes due to lack of support for strings over the wire. (#2150)

* everything needed so far

* needed changes due to lack of support for strings over the wire
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmholt rjmholt rjmholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerLeonhardt @rjmholt