Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #2165 #2172

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Backport #2165 #2172

merged 1 commit into from
Sep 17, 2019

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Sep 10, 2019

Backport of #2165

Requires the following PSES PR to be merged first: PowerShell/PowerShellEditorServices#1021

PR Summary

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

…rt for optionally correcting aliases as well (added in PSSA 1.18.2). Disabled by default. (PowerShell#2165)

Requires the following PSES PR to be merged first: PowerShell/PowerShellEditorServices#1021
@rjmholt rjmholt changed the base branch from master to legacy/1.x September 10, 2019 15:17
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerLeonhardt
Copy link
Member

I've added @bergmeister to the list of reviewers - I wouldn't block if he doesn't sign off in time though. This LGTM

@TylerLeonhardt TylerLeonhardt merged commit a3b9caf into PowerShell:legacy/1.x Sep 17, 2019
@rjmholt rjmholt deleted the backport/2165 branch December 11, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants