Close other pwsh's in the VSCode instance #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkeithhill
reviewed
Feb 13, 2020
| @@ -4,7 +4,7 @@ | |||
| "windows": { | |||
| "options": { | |||
| "shell": { | |||
| "executable": "C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\powershell.exe", | |||
| "executable": "pwsh.exe", | |||
rjmholt
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
People having a hard time using the UpdatePowerShell feature and would often close VS Code which causes the MSI to close because it's a child process.
I tried using
detached:truein theSpawnConfigparameter ofspawnbut it didn't work in vscode... (it did work in a raw js file so I suspect a vscode or electron bug...)As a best effort, I have us closing all terminals named "pwsh" in hope that that will discourage folks from closing the VS Code instance that ran the MSI.
also I snuck in using pwsh for the Windows task because I'm tired of errors caused by Windows PowerShell...
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready