Fix quoting of banner for global tool #2788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
.vsts-ci/templates/ci-general.yml
Outdated
Comment on lines
15
to
16
| # Force override of unimportant errors in the install script | ||
| exit 0 |
There was a problem hiding this comment.
Already fixed this by having this step continueOnError. Please rebase from master
|
Any idea why this fixed the issue? |
Looks like it's an artefact of how the global tool starts perhaps. We deliberately single quote everything in the string, so it seemed like a logical thing to do. It seems to work now for me, where it previously did not with the error message reported in #2780 |
|
So odd... Yeah I mean if it works, ship it...but I feel like there should be in issue in PS/PS for this if it's easy to repro |
TylerLeonhardt
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes the way the startup banner is quoted so that it works with the pwsh dotnet global tool.
Fixes #2780
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready