Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pester v5 support to problem matcher #2998

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

fflaten
Copy link
Contributor

@fflaten fflaten commented Oct 9, 2020

PR Summary

This pull requests extends the problemMatcher pattern for Pester to support new timings printed by Pester v5+. This will enable vscode-powershell to also detect failed tests using a future release of Pester v5.

A related PR in Pester, pester/Pester#1700, is also required for this to work as it adds Pester 4-style output when tests are run in a vscode-task (not integrated terminal). This output is automatic and does not require the a special option like IncludeVSCodeMarker. The related PR will be released in Pester 5.1

Fix #2931

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • PR has tests NA
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@ghost ghost added Area-Pester Issue-Bug A bug to squash. labels Oct 9, 2020
@fflaten fflaten changed the title WIP: Add Pester v5 support to problem matcher Add Pester v5 support to problem matcher Oct 10, 2020
@fflaten fflaten marked this pull request as ready for review October 10, 2020 12:53
@TylerLeonhardt
Copy link
Member

Thank you so much for this!

@TylerLeonhardt TylerLeonhardt merged commit 26ad899 into PowerShell:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Pester Issue-Bug A bug to squash.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed Pester 5 tests are not shown in Problems
2 participants