Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hardcoded extension name string #3222

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Fix hardcoded extension name string #3222

merged 2 commits into from
Mar 4, 2021

Conversation

andyleejordan
Copy link
Member

Fixes #3208.

@ghost ghost added Area-Test Issue-Bug A bug to squash. labels Mar 4, 2021
rjmholt
rjmholt approved these changes Mar 4, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
test/features/ExternalApi.test.ts Show resolved Hide resolved
@andyleejordan andyleejordan force-pushed the andschwa/fix-hardcoded-string branch from a0e1d3c to 050d254 Compare March 4, 2021 20:30
@andyleejordan andyleejordan marked this pull request as ready for review March 4, 2021 20:31
@andyleejordan andyleejordan merged commit 9ce2dc3 into master Mar 4, 2021
@andyleejordan andyleejordan deleted the andschwa/fix-hardcoded-string branch March 4, 2021 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmholt rjmholt rjmholt approved these changes

Assignees
No one assigned
Labels
Area-Test Issue-Bug A bug to squash.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extension name is hardcoded, leading to failing tests
2 participants
@andyleejordan @rjmholt