Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new ReleaseTools module #3265

Merged
merged 4 commits into from
Apr 3, 2021
Merged

Create new ReleaseTools module #3265

merged 4 commits into from
Apr 3, 2021

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented Mar 30, 2021 •
edited
Loading

This PR started with some minor cleanups with me trying to delete old, unused code and then turned into me writing some a new ReleaseTools module for my needs as maintainer. Fixes #3195.

@andyleejordan andyleejordan requested a review from rjmholt March 30, 2021 04:04
@andyleejordan andyleejordan force-pushed the andschwa/clean-up branch 3 times, most recently from 392b052 to 269339b Compare April 1, 2021 21:16
andyleejordan
andyleejordan commented Apr 1, 2021
View reviewed changes
tools/ReleaseTools.psm1 Outdated Show resolved Hide resolved
rjmholt
rjmholt approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the PR to something more descriptive, like "Clean up changelog and release scripts"

tools/ReleaseTools.psm1 Outdated Show resolved Hide resolved
@andyleejordan
Copy link
Member Author

Please rename the PR to something more descriptive, like "Clean up changelog and release scripts"

@rjmholt TBF it started as a minor cleanup, but then I did more 😅

@andyleejordan andyleejordan changed the title Minor cleanup Create new ReleaseTools module Apr 2, 2021
@ghost ghost added Area-Build & Release Issue-Enhancement A feature request (enhancement). labels Apr 2, 2021
@andyleejordan andyleejordan force-pushed the andschwa/clean-up branch 2 times, most recently from 38f5790 to 67bfd77 Compare April 3, 2021 02:40
@andyleejordan
Replace changelog and publish scripts
f6ff90c 
This uses the great `PowerShellForGitHub` module.
@andyleejordan andyleejordan merged commit 473effd into master Apr 3, 2021
@andyleejordan andyleejordan deleted the andschwa/clean-up branch April 3, 2021 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmholt rjmholt rjmholt approved these changes

Assignees
No one assigned
Labels
Area-Build & Release Issue-Enhancement A feature request (enhancement).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release Automation Improvements
2 participants
@andyleejordan @rjmholt