Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vsce to 1.87.1 #3275

Merged
merged 2 commits into from
Apr 5, 2021
Merged

Update vsce to 1.87.1 #3275

merged 2 commits into from
Apr 5, 2021

Conversation

andyleejordan
Copy link
Member

Replaces #3273.

@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Build & Release labels Apr 5, 2021
@andyleejordan andyleejordan requested a review from rjmholt April 5, 2021 22:04
dependabot-preview bot and others added 2 commits April 5, 2021 15:15
Bumps [vsce](https://github.com/Microsoft/vsce) from 1.85.1 to 1.87.1.
- [Release notes](https://github.com/Microsoft/vsce/releases)
- [Commits](microsoft/vscode-vsce@v1.85.1...v1.87.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Upstream made a breaking change by introducing a dash into the option.
@andyleejordan andyleejordan force-pushed the andschwa/vsce-update branch from 96f9148 to dae8ed2 Compare April 5, 2021 22:15
@rjmholt
Copy link
Contributor

rjmholt commented Apr 5, 2021

We should also open an issue on vsce just to register that they broke us again

@andyleejordan andyleejordan merged commit 8d207e6 into master Apr 5, 2021
@andyleejordan andyleejordan deleted the andschwa/vsce-update branch April 5, 2021 22:43
@andyleejordan
Copy link
Member Author

This brings in microsoft/vscode-vsce@83163ed which fixes a subtle break in our changelog where, on the marketplace, all the #xyzs are auto-linked directly and don't obey the actual link we put in the changelog (which was supposed to be fixed, but there was a weird implicit behavior of their commander dependency that caused it not to be, but now it's fixed, microsoft/vscode-vsce#542).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build & Release Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants