Update Description to reflect that PowerShell is for more than scripting #3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
/cc @joeyaiello @SydneyhSmith for language suggestions |
|
LGTM, thanks for the PR @potatoqualitee |
andyleejordan
approved these changes
May 7, 2021
| @@ -271,7 +271,7 @@ function Update-Version { | |||
| # TODO: Maybe cleanup the replacement logic. | |||
| switch ($RepositoryName) { | |||
| "vscode-powershell" { | |||
| $d = "Develop PowerShell scripts in Visual Studio Code!" | |||
| $d = "Develop PowerShell modules, commands and scripts in Visual Studio Code!" | |||
There was a problem hiding this comment.
Thanks for catching this 😁
| @@ -141,12 +141,12 @@ task UpdatePackageJson { | |||
| if ($script:IsPreviewExtension) { | |||
| $script:PackageJson.name = "powershell-preview" | |||
| $script:PackageJson.displayName = "PowerShell Preview" | |||
| $script:PackageJson.description = "(Preview) Develop PowerShell scripts in Visual Studio Code!" | |||
| $script:PackageJson.description = "(Preview) Develop PowerShell modules, commands and scripts in Visual Studio Code!" | |||
There was a problem hiding this comment.
Omg what is this script doing. @rjmholt?!
andyleejordan
added
Area-Documentation
Issue-Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Updates the description to reflect that PowerShell is a powerful language. Fixes #3339.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready