Fix #401 and #421 #568
Merged
Fix #401 and #421 #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error This change improves a previous fix where we report an unsupported PowerShell version when the user attempts to start the extension. The previous fix utilized ConvertTo-Json to write out the session details; this caused a failure since this cmdlet was introduced in PowerShell v3. We now write out teh JSON manually in this case.
…orted This change adds an additional check in the Start-EditorServices.ps1 script to see whether the LanguageMode has been locked to an unsupported mode like ConstrainedLanguage. The language server cannot be loaded and used in this case so the user should be notified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.