-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new integrated console settings #590
Conversation
This change adds two new settings to control the automatic loading of the PowerShell extension and integrated console: - `powershell.startAutomatically` - `powershell.integratedConsole.showOnStartup` Both of which default to `true`. Resolves PowerShell#580.
This change adds a new setting that controls whether focus changes to the integrated console when scripts are executed or debugged: - `powershell.integratedConsole.focusConsoleOnExecute` When true, it causes the focus to get set to the console on any script execution. It is set to true by default to ensure that screen readers pick up the execution output once it starts. Resolves PowerShell#588.
@rkeithhill What do you think about the name of the |
So this really is whether to actually start PSES? Is there no way to start the extension but not automatically show the IC? |
@rkeithhill There are two separate settings here, one is to automatically start PSES and the other is to automatically show the console when PSES starts. In the original issue that was filed (#580), the author asked if we could add a setting to defer starting PSES until later. |
This change adds a couple of environment variables to the appveyor.yml to speed up builds of PowerShell Editor Services by disabling package caching and telemetry.
Not starting PSES seems a bit strange given it occurs in the background (spinning up a different process). I wouldn't think it would impact editing performance that much. But that said, the setting name seems correct to me. I wonder how long it will be before we get an issue that the extension isn't working because someone set this setting to true? 😛 |
Starting up PSES does have some impact on slower machines just due to another process loading and taking up CPU cycles, but I suppose it isn't happening in the foreground so it isn't blocking the user from using the editor. I'll leave the setting in for now even though there's a risk of someone shooting off their foot ;) |
See commits for more information.