Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new integrated console settings #590

Merged
merged 5 commits into from
Mar 20, 2017

Conversation

daviwil
Copy link
Contributor

@daviwil daviwil commented Mar 20, 2017

See commits for more information.

daviwil added 2 commits March 20, 2017 14:32
This change adds two new settings to control the automatic loading of the
PowerShell extension and integrated console:

- `powershell.startAutomatically`
- `powershell.integratedConsole.showOnStartup`

Both of which default to `true`.

Resolves PowerShell#580.
This change adds a new setting that controls whether focus changes to the
integrated console when scripts are executed or debugged:

- `powershell.integratedConsole.focusConsoleOnExecute`

When true, it causes the focus to get set to the console on any script
execution.  It is set to true by default to ensure that screen readers
pick up the execution output once it starts.

Resolves PowerShell#588.
@daviwil daviwil added this to the 0.11.0 milestone Mar 20, 2017
@daviwil
Copy link
Contributor Author

daviwil commented Mar 20, 2017

@rkeithhill What do you think about the name of the powershell.startAutomatically setting? Any better ideas?

@rkeithhill
Copy link
Contributor

So this really is whether to actually start PSES? Is there no way to start the extension but not automatically show the IC?

@daviwil
Copy link
Contributor Author

daviwil commented Mar 20, 2017

@rkeithhill There are two separate settings here, one is to automatically start PSES and the other is to automatically show the console when PSES starts. In the original issue that was filed (#580), the author asked if we could add a setting to defer starting PSES until later.

daviwil added 2 commits March 20, 2017 15:36
This change adds a couple of environment variables to the appveyor.yml to
speed up builds of PowerShell Editor Services by disabling package caching
and telemetry.
@rkeithhill
Copy link
Contributor

rkeithhill commented Mar 20, 2017

Not starting PSES seems a bit strange given it occurs in the background (spinning up a different process). I wouldn't think it would impact editing performance that much. But that said, the setting name seems correct to me.

I wonder how long it will be before we get an issue that the extension isn't working because someone set this setting to true? 😛

@daviwil
Copy link
Contributor Author

daviwil commented Mar 20, 2017

Starting up PSES does have some impact on slower machines just due to another process loading and taking up CPU cycles, but I suppose it isn't happening in the foreground so it isn't blocking the user from using the editor. I'll leave the setting in for now even though there's a risk of someone shooting off their foot ;)

@daviwil daviwil merged commit 10395d7 into PowerShell:develop Mar 20, 2017
@daviwil daviwil deleted the console-settings branch March 20, 2017 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants