Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG in SSL certificates assignment to bindings #332

Closed
konste opened this issue Feb 8, 2018 · 12 comments · Fixed by #437
Closed

BUG in SSL certificates assignment to bindings #332

konste opened this issue Feb 8, 2018 · 12 comments · Fixed by #437
Labels
bug The issue is a bug.

Comments

@konste
Copy link

konste commented Feb 8, 2018

Repro:

$BindingInfo = @(
    New-CimInstance -ClassName MSFT_xWebBindingInformation -Namespace root/microsoft/Windows/DesiredStateConfiguration -Property @{
        Protocol              = 'https'
        IPAddress             = '*'
        Port                  = 443
        HostName              = 'api.bittitan.com'
        CertificateThumbprint = '34AE59F4CFA28602716C46D172850747B36624D8'
        CertificateStoreName  = 'WebHosting'
        SslFlags              = 1
    } -ClientOnly
    New-CimInstance -ClassName MSFT_xWebBindingInformation -Namespace root/microsoft/Windows/DesiredStateConfiguration -Property @{
        Protocol              = 'https'
        IPAddress             = '*'
        Port                  = 443
        HostName              = '*.migrationwiz.com'
        CertificateThumbprint = 'DE0A409C2F2BF8DF47C9154EDE3C3309CAB9E0F7'
        CertificateStoreName  = 'WebHosting'
        SslFlags              = 1
    } -ClientOnly
)

Update-WebsiteBinding -Name MigrationWiz -BindingInfo $BindingInfo

Despite different CertificateThumbprint specified for the first and second binding BOTH get the same (first) certificate assigned!

@konste
Copy link
Author

konste commented Feb 8, 2018

I have found the bug. Would it help if I work on PR? I have noticed very little activity on that project and don't want to waste time if it is not needed.

remcoeissing added a commit to remcoeissing/xWebAdministration that referenced this issue Feb 16, 2018
@rsawer
Copy link

rsawer commented Mar 1, 2018

I have the same issue here, seems that it appeared after version 1.17.0.0 or I've missed that somehow

@konste
Copy link
Author

konste commented Apr 9, 2018

@remcoeissing Any chances to see recent fixes released soon?

@Davidsod
Copy link

I'm having the same problem (#346) as mentioned here, REALLY appreciate if this will be fixed soon :)

@johlju
Copy link
Member

johlju commented Apr 23, 2018

Not sure there are a PR for this? I label this as help wanted so that someone in the community can run with it.

@johlju johlju added bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community. labels Apr 23, 2018
@konste
Copy link
Author

konste commented Apr 23, 2018

I plan to work on it today and hopefully have a PR soon. I’m also tired of working around this issue every time.

@johlju
Copy link
Member

johlju commented Apr 23, 2018

@konste awesome! Then I label this as in progress, let me know if that changes (you get other prioritize) .

@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Apr 23, 2018
konste pushed a commit to konste/xWebAdministration that referenced this issue Apr 23, 2018
@konste
Copy link
Author

konste commented Apr 23, 2018

@johlju , @Davidsod , PR created: #347

One test is failing, but it is not caused by my change. It is separate issue #302

@Davidsod
Copy link

@konste , Just patched my servers and it works like MAGIC! really appreciate it!

@Davidsod
Copy link

Obviously, it would be nice to have this fixed through xWebAdministration package of course :)

@typozh
Copy link

typozh commented Jul 11, 2018

We need this to be fixed! We can't use the new xIisFeatureDelegation resource in version 2.0.0.0 as this breaks our website bindings! Any idea when this will be available in a new version?
Thanks!

@johlju
Copy link
Member

johlju commented Jul 11, 2018

PR #347 is abandoned (no activity for over two weeks since it opened), so currently no one in the community is working on this. Anyone may pick up the abandoned PR and continue the work.

johlju pushed a commit that referenced this issue Sep 6, 2019
…irst (#437)

- Fix multiple HTTPS bindings on one xWebsite receiving the first binding's certificate [#332](#332)
  - Added unit regression test
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Sep 6, 2019
johlju pushed a commit that referenced this issue Sep 29, 2019
…dividual log flags (#440)

- Changes to xWebsite
  - Fix `Get-TargetResource` so that `LogFlags` are returned as expected
    array of strings (one for each flag) rather than an array containing
    a single comma-separated string of flags' (issue #332).
- Changes to xIISLogging
  - Fix `Get-TargetResource` so that `LogFlags` are returned as expected
  array of strings (one for each flag) rather than an array containing a
  single comma-separated string of flags (issue #332).
gstorme pushed a commit to gstorme/xWebAdministration that referenced this issue Feb 14, 2020
…irst (dsccommunity#437)

- Fix multiple HTTPS bindings on one xWebsite receiving the first binding's certificate [dsccommunity#332](dsccommunity#332)
  - Added unit regression test
gstorme pushed a commit to gstorme/xWebAdministration that referenced this issue Feb 14, 2020
…dividual log flags (dsccommunity#440)

- Changes to xWebsite
  - Fix `Get-TargetResource` so that `LogFlags` are returned as expected
    array of strings (one for each flag) rather than an array containing
    a single comma-separated string of flags' (issue dsccommunity#332).
- Changes to xIISLogging
  - Fix `Get-TargetResource` so that `LogFlags` are returned as expected
  array of strings (one for each flag) rather than an array containing a
  single comma-separated string of flags (issue dsccommunity#332).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug.
Projects
None yet
5 participants