-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xWebSite: Fix for the issue #332 #347
Conversation
Thanks for this! Appreciate you resolving this! 😄 Reviewed 1 of 1 files at r1. a discussion (no related file): a discussion (no related file): Comments from Reviewable |
Labeling this PR as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on the PR is taken up again. |
Seems like a tiny change to get that fix in, so I removed the abandoned label and will try to get back to it in the near future. @konste if you have time to solve the points made in the review that'd be much appreciated (especially the entry in release notes). |
This issue is affecting our organization as well, and we had to disable DSC configuration of our web bindings for the time being. Just to confirm, all that's needed is a test and a change log entry before it can be merged, right? |
Right. |
@mcbobke yes, just a regression test (that would fail if this change is not applied), and a change log entry explaining what the change resolves. Tag me for review as soon as that is resolved in this PR or another PR is sent in that closes this one, whatever is simplest. 😄 |
Sounds good! I'll be working on this. |
I am sorry, I left this area a while ago. @mcbobke please let me know if you need anything from me to push the fix through. |
@johlju , here you go - one line fix!
Fixes #332
This change is