Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xWebSite: Fix for the issue #332 #347

Closed
wants to merge 1 commit into from
Closed

Conversation

konste
Copy link

@konste konste commented Apr 23, 2018

@johlju , here you go - one line fix!

Fixes #332


This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Apr 24, 2018
@johlju
Copy link
Member

johlju commented Apr 24, 2018

Thanks for this! Appreciate you resolving this! 😄


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


a discussion (no related file):
Could you please add a regression unit test that tests multiple certificates so the result of this is correct and we don't get this problem down the road?


a discussion (no related file):
Please add a new entry to the change log for this change.


Comments from Reviewable

@johlju johlju added waiting for author response The pull request is waiting for the author to respond to comments in the pull request. and removed needs review The pull request needs a code review. labels Apr 24, 2018
@johlju johlju changed the title Fix for the issue #332. Fix for the issue #332 Apr 27, 2018
@johlju johlju changed the title Fix for the issue #332 xWebSite: Fix for the issue #332 Apr 27, 2018
@johlju johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed waiting for author response The pull request is waiting for the author to respond to comments in the pull request. labels May 1, 2018
@johlju
Copy link
Member

johlju commented May 23, 2018

Labeling this PR as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on the PR is taken up again.

@johlju johlju added abandoned The pull request has been abandoned. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels May 23, 2018
@gaelcolas gaelcolas added waiting for author response The pull request is waiting for the author to respond to comments in the pull request. and removed abandoned The pull request has been abandoned. labels Mar 15, 2019
@gaelcolas
Copy link
Member

Seems like a tiny change to get that fix in, so I removed the abandoned label and will try to get back to it in the near future.

@konste if you have time to solve the points made in the review that'd be much appreciated (especially the entry in release notes).

@mcbobke
Copy link
Contributor

mcbobke commented Sep 4, 2019

This issue is affecting our organization as well, and we had to disable DSC configuration of our web bindings for the time being. Just to confirm, all that's needed is a test and a change log entry before it can be merged, right?

@konste
Copy link
Author

konste commented Sep 4, 2019

Right.

@johlju
Copy link
Member

johlju commented Sep 4, 2019

@mcbobke yes, just a regression test (that would fail if this change is not applied), and a change log entry explaining what the change resolves.

Tag me for review as soon as that is resolved in this PR or another PR is sent in that closes this one, whatever is simplest. 😄

@mcbobke
Copy link
Contributor

mcbobke commented Sep 4, 2019

Sounds good! I'll be working on this.

@konste
Copy link
Author

konste commented Sep 4, 2019

I am sorry, I left this area a while ago. @mcbobke please let me know if you need anything from me to push the fix through.

@mcbobke
Copy link
Contributor

mcbobke commented Sep 4, 2019

I appreciate the offer @konste ! I just created #437 to move forward from here.

@johlju johlju closed this in #437 Sep 6, 2019
@johlju johlju removed the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG in SSL certificates assignment to bindings
4 participants