This repository has been archived by the owner on Apr 24, 2020. It is now read-only.
vcs: Disable alias of grep to fix performance penalty #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If user defined alias of grep command with '-r' or '--recursive' option, it causes a slow response of command line. It is not unexpected behavior of vcs info. This commit explicitly disables alias of grep to suppress side effects.
kenhys
changed the title
|
@kenhys - Wow! This is great! This is a subtle issue with a big impact. Thanks so much for upstreaming the fix! I really appreciate it. Welcome to P9k |
dritter
added a commit
to dritter/powerlevel9k
that referenced
this pull request
Jun 6, 2018
… staging_065 Conflicts were: - functions/vcs.zsh: Two commits avoided wrapper behaviour. Powerlevel9k#685 in grep, Powerlevel9k#797 in git.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user defined alias of grep command with '-r' or '--recursive'
option, it causes a slow response of command line. It is not
unexpected behavior of vcs info.
This commit explicitly disables alias of grep to suppress side
effects.