Fix font issue debugging script

[dritter]

The new GitHub Issue Templates show that a lot of folks have trouble with fonts and problems with the debug/font-issues.zsh script. The script is a port of the font detection from dylanaraps/neofetch. In the our previous version I missed some functions (get_ppid and get_process_name) that now cause trouble.
Last but not least, I updated the font detections functions.

It would be super helpful if somebody could test this under WSL and Linux.

[JulienPivard]

All seems to be ok with Macos.

But with my Linux (debian) I have an error with ps.

error: improper list

Usage:
 ps [options]
...

So I took a look in your code and it look like the variable $os is not set and if I add os=$(uname) at the begining of the scripts the OS detection work. But this create an other problem trim is not found, but is the use of this command necessary ? The ideal would be to avoid having to install more soft to run your script.

[JulienPivard]

If I add that function at the begining of the script

trim()
{
    local var="${*}"
    # remove leading whitespace characters
    var="${var#"${var%%[![:space:]]*}"}"
    # remove trailing whitespace characters
    var="${var%"${var##*[![:space:]]}"}"
    echo -n "${var}"
}

I have

===== Font debugging =====
You are using gnome-terminal with Font 

WARNING It does not seem like you use an Powerline-enabled or Awesome Terminal Font!
Please make sure that your font settings are correct!

I use a powerline font so I took another look in your script
and in the function get_term_font it have no case for gnome-terminal

[dritter]

Hah! Good point @JulienPivard !

As this is a port from neofetch, I'll have to lookup how they resolve their $OS. I overlooked this bug, because with a running P9K, there is a $OS present as well (but with other values probably).

I'll have a look into that tomorrow.

[JulienPivard]

I did not know there was a $OS variable. But in the script there is $os and not $OS I think the problem is there. I take a look and $os return nothing but $OS return OSX for my mac and Linux for my debian. So i think it's juste a problem with the case :)

[dritter]

You are right. Here is the code that fills $os. Our variable is names $OS.
So, either we want to change $os to $OS and make the debugging script compatible with our values, or we want to add the get_os function as well. But that are thoughts for tomorrow. ;)

[dritter]

@JulienPivard I (hopefully) fixed the font debugging script. Could you give it another try?

[JulienPivard]

get_process_name:10: aucun fichier ou dossier de ce type: /proc/ 1960/comm
grep: /proc/ 1960/status: No such file or directory
===== Font debugging =====
You are using  with Font 

WARNING It does not seem like you use an Powerline-enabled or Awesome Terminal Font!
Please make sure that your font settings are correct!

I think trim don't remove all the space.

[dritter]

Strange.. This must be broken in the original repo as well.. Anyway. I fixed it now.

[JulienPivard]

It's work... for trim

===== Font debugging =====
You are using gnome-terminal with Font 

WARNING It does not seem like you use an Powerline-enabled or Awesome Terminal Font!
Please make sure that your font settings are correct!

[JulienPivard]

if I have the time I would try with other terminals.

[bhilburn]

Great idea, @dritter! This should help quite a bit. I would love to get this in for v0.6.6 to help with debugging going forward. Would you like to do further testing or is this ready to go?

@julienfalque - Thanks so much for spending the time to help us test this! That is extremely valuable for the project =)

[dritter]

@JulienPivard It would be great, if you could test this on other terminals as well!

@bhilburn I think we need a bit testing here. I'll try to test it soon (probably next week). But the Gnome Issue should be fixed in the neofetch repo. I want to keep the difference as small as possible, to be able to copy the code in the future again.

[bhilburn]

This is now fixed in master, and the v0.6.6 release will include the fix. Thanks so much!