Skip to content
This repository has been archived by the owner on Apr 24, 2020. It is now read-only.

Fix broken link in README referencing date and time configuration #956

Merged
merged 1 commit into from
Aug 31, 2018

Conversation

nnja
Copy link
Contributor

@nnja nnja commented Aug 17, 2018

Fix broken link referencing zsh date and time configuration in prompt expansion.

The current broken link points to http://zsh.sourceforge.net/Doc/Release Prompt-Expansion.html, while the correct link is http://zsh.sourceforge.net/Doc/Release/Prompt-Expansion.html#Date-and-time

Thank you so much for opening a PR for P9k! Many of our best features and segments have come from the community, and we are excited to see your contribution.

To help you make the best PR, here are some guidelines:

  • The master branch is our stable branch, and the next branch is our development branch. If you are submitting a bug fix, please file your PR against master. If it is a new feature, enhancement, segment, or something similar, please submit it against next. For more information, please see our Developer's Guide.
  • We maintain unit tests for segments and features in the test directory. Please add unit tests for anything new you have developed! If you aren't sure how to do this, go ahead and file your PR and ask for help!
  • For running manual tests in different environments, we have Vagrant and Docker configurations. Please see the Test README and make sure your new feature is working as expected!
  • If your PR requires user configuration, please make sure that it includes an update to the README describing this.
  • P9k maintains a lot of useful information in our Wiki. Depending on the content of your PR, we might ask you to update the Wiki (or provide text for us to use) to document your work. Most PRs don't require this.
  • Please make your commit messages useful! Here is a great short guide on useful commit messages.

Once you have submitted your PR, P9k core contributors will review the code and work with you to get it merged. During this process, we might request changes to your code and discuss different ways of doing things. This is all part of the open source process, and our goal is to help you create the best contribution possible for P9k =).

Please follow this template for creating your PR:

Title

Please make the title of your PR descriptive! If appropriate, please prefix the title with one of these tags:

  • [Bugfix]
  • [New Segment]
  • [Docs]
  • [Enhancement]

Description

Please describe the contribution your PR makes! Screenshots are especially helpful, here, if it's a new segment.

If your PR is addressing an issue, please reference the Issue number here.

Questions

Is there something in your PR you're not sure about or need help with? Is there a particular piece of code you would like feedback on? Let us know here!

Fix broken link referencing zsh date and time configuration in prompt expansion. 

The current broken link points to `http://zsh.sourceforge.net/Doc/Release Prompt-Expansion.html`, while the correct link is http://zsh.sourceforge.net/Doc/Release/Prompt-Expansion.html#Date-and-time
@dritter
Copy link
Member

dritter commented Aug 17, 2018

Hi @nnja !

Good catch. Thanks for the fix. I merged it in #944 , the preparation branch for the upcoming release. :)

@dritter dritter mentioned this pull request Aug 17, 2018
@bhilburn bhilburn merged commit cd723e7 into Powerlevel9k:master Aug 31, 2018
@bhilburn
Copy link
Member

Merged into master as part of #944! Will be in the v0.6.6 release.

@nnja nnja deleted the patch-1 branch September 10, 2018 04:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants