Fix importing in Python 3.5.2 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Ubuntu 16.04, which has Python 3.5.2, `apns2.client` failed to import, because `typing.Deque` was not added until Python 3.5.4. Fixes Pr0Ger#88. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
On Ubuntu 16.04, which has Python 3.5.2, this raised `TypeError: descriptor '__subclasses__' of 'type' object needs an argument` (python/typing#266). Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
changed the title
|
@Pr0Ger do you have a timeline on this fix being merged and released on PyPI? We're running Debian which has 3.5.3, I can imagine this is impacting a fair number of people. |
|
@andersk Thanks for contribution! @danpalmer From my experience most people nowadays deploy their apps via docker images instead of relying on python from their host system. Anyway, 0.7.1 version is available now on PyPI |
|
Amazing, thanks for this!
Unfortunately distribution on host systems is still the significant majority of deployments from the stats I’ve seen. We’re starting to move to containerised deployments, but many people depend on LTS releases from Ubuntu or Debian because of the great stability.
… On 8 Oct 2019, at 21:00, Sergey Petrov ***@***.***> wrote:
@andersk Thanks for contribution!
@danpalmer From my experience most people nowadays deploy their apps via docker images instead of relying on python from their host system. Anyway, 0.7.1 version is available now on PyPI
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
andersk
added a commit
to andersk/zulip
that referenced
this pull request
Oct 8, 2019
My PR Pr0Ger/PyAPNs2#90 fixing Python 3.5.2 support was merged. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
andersk
added a commit
to andersk/zulip
that referenced
this pull request
Oct 8, 2019
My PR Pr0Ger/PyAPNs2#90 fixing Python 3.5.2 support was merged. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
timabbott
pushed a commit
to zulip/zulip
that referenced
this pull request
Oct 9, 2019
My PR Pr0Ger/PyAPNs2#90 fixing Python 3.5.2 support was merged. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
evo42
pushed a commit
to evo42/zulip
that referenced
this pull request
Oct 30, 2019
My PR Pr0Ger/PyAPNs2#90 fixing Python 3.5.2 support was merged. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
YashRE42
pushed a commit
to YashRE42/zulip
that referenced
this pull request
Dec 12, 2019
My PR Pr0Ger/PyAPNs2#90 fixing Python 3.5.2 support was merged. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Ubuntu 16.04, which has Python 3.5.2,
apns2.clientfailed to import, becausetyping.Dequewas not added until Python 3.5.4, andOptional[Type[JSONEncoder]]threw an error until Python 3.5.3 (python/typing#266).Fixes #88.